chore: Describe RBAC rules, remove unnecessary rules#810
Open
NickLarsenNZ wants to merge 10 commits intomainfrom
Open
chore: Describe RBAC rules, remove unnecessary rules#810NickLarsenNZ wants to merge 10 commits intomainfrom
NickLarsenNZ wants to merge 10 commits intomainfrom
Conversation
16 tasks
- Add missing description - Remove `get`, it is never used - Make list/watch unconditional
NickLarsenNZ
commented
Mar 27, 2026
Comment on lines
-170
to
-177
| - apiGroups: | ||
| - "" | ||
| resources: | ||
| - configmaps | ||
| - secrets | ||
| - serviceaccounts | ||
| verbs: | ||
| - get |
Member
Author
There was a problem hiding this comment.
I removed these permissions (as I did for the Airflow product ClusterRole), and tests ran fine. It looks like copy/pasta.
@adwk67 do you have any reason to think Druid needs runtime access to k8s Secrets?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of stackabletech/issues#798
Note
This was initially generated by a coding assistant to see how well it can inspect code and review the RBAC rules. the changes will be properly checked before reviews are requested.
Explanation
Details
● Removed entirely
there's no harm removing this entirely.
● Verb removals
to react to changes in these resources.
gets a 403 and silently skips — which is the intended behaviour.
DruidCluster object itself.
● The reorganisation was a direct consequence of the verb changes. The original file grouped pods, configmaps, secrets, services, endpoints, and serviceaccounts into a single rule because they all shared the same verb set:
verbs: [create, delete, get, list, patch, update, watch]
After the audit, those resources need different subsets of verbs:
A single RBAC rule applies its verb list uniformly to all resources in it, so you can't express "list+watch for configmaps but not for secrets" in one rule. The only way to set different verbs per resource is to split them into
separate rules.